alphapapa / frame-purpose.el

Purpose-specific frames for Emacs
GNU General Public License v3.0
52 stars 4 forks source link

Cannot show sidebar #17

Open manufactory opened 3 years ago

manufactory commented 3 years ago

Hello,

Calling frame-purpose-show-sidebar gives me the error message:

frame-purpose-show-sidebar: No clause matching ‘nil’

I just reproduced this with emacs -Q and only frame-purpose loaded in the following steps:

  1. Enter in *scratch*, call M-x frame-purpose-mode and eval the example from the readme

    (frame-purpose-make-frame :modes 'org-mode
                          :title "Org")
  2. Create two new buffers; /tmp/foo.org and /tmp/foo.bar

  3. Call frame-purpose-show-sidebar

I'm running

alphapapa commented 3 years ago

Thanks for reporting.

alphapapa commented 3 years ago

Please let me know if that fixes it for you.

manufactory commented 3 years ago

Thanks for working on this so quickly! When I start a fresh emacs instance (using -Q again), create two .org files and call M-x frame-purpose-show-sidebar, I get a sidebar, however it shows not only the Org-buffers:

*Minibuf-0*
*frame-purpose-buffers for frame: Org*
bar.org
foo.org
 *Echo Area 1*
*scratch*
 *Echo Area 0*
 *Minibuf-1*
*Completions*
init.el
*Messages*
 *code-conversion-work*

When I then close the sidebar using C-x C-k and call M-x frame-purpose-show-sidebar again, no sidebar but an error message is shown: frame-purpose-show-sidebar: Symbol’s function definition is void: nil.

I also noticed that the frame-purpose-make-frame returns a frame now, before the recent changes it returned nil

alphapapa commented 3 years ago

Thanks.