alphapapa / makem.sh

Makefile-like script for linting and testing Emacs Lisp packages
GNU General Public License v3.0
163 stars 13 forks source link

Fix: Escape dots in `filter-files-exclude-default` regex #32

Closed fritzgrabo closed 10 months ago

fritzgrabo commented 3 years ago

Just a trivial fix in the filter-files-exclude-default regular expression: I escaped the dots where needed to make sure the regex doesn't accidentally match when it shouldn't.

Before:

(/\.cask/|-autoloads.el|.dir-locals)

After:

(/\.cask/|-autoloads\.el|\.dir-locals)

I only noticed this because I'm working on a package named foobar-dir-locals.el and hit this error:

$ make all
ERROR (2021-02-08 23:58:35): No files specified and not in a git repo.
make: *** [all] Error 1

With the proposed fix in place, everything works as expected.

PS: Thanks so much for this script -- together with Steve Purcell's package-lint, it's been a great help as I start writing and publishing my first packages 🙌

alphapapa commented 3 years ago

Thanks for catching that. I'll update the changelog and merge this when I have time.

Thanks also for the kind words. I'm glad it's helpful to you. See also https://github.com/alphapapa/emacs-package-dev-handbook for more resources.

alphapapa commented 10 months ago

This is finally merged. Thanks for your patience.