search

alphapapa / makem.sh

Makefile-like script for linting and testing Emacs Lisp packages
GNU General Public License v3.0
163 stars 13 forks source link

Install the correct dependency version into the sandbox #41

Closed josephmturner closed 10 months ago

josephmturner commented 1 year ago

Example problem: When a built-in dependency has newer version available on ELPA, and the newer version is specified in the Package-Requires of our package, the newer version is not installed, and makem tests our package using the older, built-in version.

makem could call package-install to install the library as a package, which would use the built-in machinery to install dependencies at their correct versions.

alphapapa commented 1 year ago

Thanks. I think this is technically a bug, because even if --install-deps is used, that won't cause a built-in package to be upgraded to the ELPA version. It just happens rarely in practice (so far, anyway--it's likely to happen more often as more core packages are also put on ELPA).

josephmturner commented 1 year ago

IIUC, this bug is causing the hyperdrive.el build manifests to fail since the tests are running with the built-in version instead of the latest version which includes this fix.

josephmturner commented 10 months ago

Thank you!! Adam Porter @.***> writes:

Closed #41 as completed via d13527f.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.