search

alphapapa / makem.sh

Makefile-like script for linting and testing Emacs Lisp packages
GNU General Public License v3.0
163 stars 13 forks source link

Indent-lint limitation #5

Closed conao3 closed 4 years ago

conao3 commented 4 years ago

Thanks to find my package, indent-lint. This package has below limitation for now.

alphapapa commented 4 years ago

Thanks.

conao3 commented 4 years ago

I resolved all the listed limitations. I'm not familiar with makem, so please test indent-lint through makem.

alphapapa commented 4 years ago

Thanks, will test again when MELPA rebuilds.

DamienCassou commented 4 years ago

Great example of a successful collaboration. Thank you guys.

alphapapa commented 4 years ago

@conao3 FYI, there's just one more issue: when there is an indentation mismatch, the function indent-lint-batch does not use (kill-emacs 1), which prevents the calling script from detecting whether any indentation mismatches were detected.

I could work around this in makem.sh by providing a wrapper, but I'm guessing you'd prefer to fix it in indent-lint to match the behavior of, e.g. package-lint-batch-and-exit and ert-run-tests-batch-and-exit. You might consider adding an additional indent-lint-batch-and-exit function that works like they do.

Thanks.

alphapapa commented 4 years ago

@conao3 BTW, @noctuid just pointed me to https://github.com/gonewest818/elisp-lint, which includes this simple function to test indentation. Maybe you'll find it useful: https://github.com/gonewest818/elisp-lint/blob/master/elisp-lint.el#L169

conao3 commented 4 years ago

Exitcode issue solved at https://github.com/conao3/indent-lint.el/pull/22. And thanks for letting me know elisp-lint project.

alphapapa commented 4 years ago

Thanks!