Python2-3 compatibility fixes

alphapapa / org-protocol-capture-html

Capture HTML from the browser selection into Emacs as org-mode content

453 stars 39 forks source link

Python2-3 compatibility fixes #31

Closed samspills closed 5 years ago

samspills commented 5 years ago

This PR fixes two compatibility issues with python3 in the urlencode function.

import print_function from future, and use print()
use the imported quote instead of urllib.quote

alphapapa commented 5 years ago

Hi,

Thanks for the PR, and sorry for the delay.

Can you confirm that the code now works properly on both Python 2 and Python 3?

Thanks.

samspills commented 5 years ago

No worries!! With my changes, I can run the shell script using either python 2.7.16 or python 3.7.3. Any intermediate versions of python should also work.

samspills commented 5 years ago

@alphapapa Can this be merged?

alphapapa commented 5 years ago

Thanks for your patience!