search

alphapapa / org-ql

A searching tool for Org-mode, including custom query languages, commands, saved searches and agenda-like views, etc.
GNU General Public License v3.0
1.4k stars 110 forks source link

Fix: (org-ql-completing-read) Store markers as text property #357

Closed anpandey closed 1 year ago

anpandey commented 1 year ago

Fixes #350

oantolin commented 1 year ago

Ha! I just added a text property storing the marker to my local copy of org-ql! I didn't do it to fix #350, but to enable embark actions on headings listed by org-ql-find. If this gets merged, and the org-ql-completing-read completion table gets a category metadatum, then I can easily write a tiny org-ql-embark package offering support for embark-collect and for using Org heading actions on org-ql-find candidates.

alphapapa commented 1 year ago

Ha! I just added a text property storing the marker to my local copy of org-ql! I didn't do it to fix #350, but to enable embark actions on headings listed by org-ql-find. If this gets merged, and the org-ql-completing-read completion table gets a category metadatum, then I can easily write a tiny org-ql-embark package offering support for embark-collect and for using Org heading actions on org-ql-find candidates.

That sounds like a great plan. Thank you.

oantolin commented 1 year ago

The future org-ql-embark package should also make embark-export called from org-ql-find produce an agenda mode buffer like the ones org-ql-search makes ---which I think shouldn't be hard to do either.

alphapapa commented 1 year ago

The future org-ql-embark package should also make embark-export called from org-ql-find produce an agenda mode buffer like the ones org-ql-search makes ---which I think shouldn't be hard to do either.

Yes, this would probably best be done similarly to helm-org-ql, which allows an org-ql-view buffer to be produced from a set of results (ideally org-ql-find would provide the same features as helm-org-ql, it's just yet to be implemented). Then embark-export would just need to call the corresponding org-ql command; none of the logic should be necessary inside of embark itself.

alphapapa commented 1 year ago

Thanks to all for helping, and for your patience!