search

alphapapa / org-ql

A searching tool for Org-mode, including custom query languages, commands, saved searches and agenda-like views, etc.
GNU General Public License v3.0
1.35k stars 104 forks source link

Obsolete macro's in emacs build 30.0.50 (org-ql) #414

Open Algon-DK opened 4 months ago

Algon-DK commented 4 months ago

OS/platform

macOS Sonoma 14.3.1

Emacs version and provenance

Building Emacs from source version 30.0.50 (own build)

Emacs command

n/a

Org version and provenance

n/a. org version 9.6

org-ql package version and provenance

Melpa -- Version: 0.7-pre

Actions taken

none

Observed results

compile warning:

Warning: 'pcase--flip' is an obsolete macro (as of 30.1); use '_' instead

comes from both org-ql-view and org-ql-search

Expected results

n/a

Backtrace

No response

Etc.

annoying, but not fatal error, that will be in the future

alphapapa commented 4 months ago

Hello Nils,

Please see these recent commits to emacs.git:

Please note that pcase--flip is not present in org-ql's source code, so there is nothing to be done here. You might want to package-recompile org-ql and/or its dependencies on your end.

You can expect some occasional issues like this when running pre-release versions of Emacs that you've built yourself. You should generally check with upstream rather than downstream when encountering them. (This is the third report about this change that has been filed against my packages, despite there not being a problem for me to fix.)

@monnier Just FYI. The fallout from your very reasonable and welcome change seems much larger than I would have expected.

monnier commented 4 months ago

@monnier Just FYI. The fallout from your very reasonable and welcome change seems much larger than I would have expected.

No good deed goes unpunished 🙂