Open anpandey opened 4 months ago
Thanks, but please hold off on any further PRs until you've done the copyright assignment: https://github.com/alphapapa/org-ql/pull/325#issuecomment-1958871852 And until then, please convert this to a draft PR.
Regarding the code:
txt
property's value were returned from a function (so that function itself could be tested).What do you think?
Sure, I'll convert this to a draft. I'm currently waiting for a reply regarding the copyright assignment forms.
I agree with (1). We could use org agenda functions like org-agenda-compare-effort
to see if the property can be properly read by org. I don't think I know enough about how the existing tests to have an opinion on (2) yet. I would prefer to go from end-to-end from org element to testing and agenda entry (simply because it has more coverage), but I can understand if this ends up being too hard to implement.
Thanks.
We have two choices with testing:
Related to #370