Fix: Use equal to compare lists

alphapapa / org-ql

A searching tool for Org-mode, including custom query languages, commands, saved searches and agenda-like views, etc.

GNU General Public License v3.0

1.35k stars 104 forks source link

Fix: Use equal to compare lists #436

Closed akirak closed 4 days ago

akirak commented 1 week ago

eq is not a proper way to compare the structures of two Lisp objects. I spontaneously discovered this trivial mistake while investigating on another issue, but nobody pointed it out before?

alphapapa commented 1 week ago

That would be #430. :)

akirak commented 1 week ago

I see. You just didn't work on it yet. It's fine anyway, as you must be busy dealing with other issues.

alphapapa commented 1 week ago

Yeah, I noticed this recently (or someone showed me, I forget), but this code has been incorrect for several releases without anyone noticing, including myself, so it doesn't seem urgent.