search

alphapapa / org-sidebar

A helpful sidebar for Org mode
GNU General Public License v3.0
527 stars 16 forks source link

Change: Don't depend on deprecated dash-functional #45

Closed basil-conto closed 2 years ago

basil-conto commented 3 years ago

Dash 2.18.0 now subsumes dash-functional.

See https://github.com/magnars/dash.el/blob/master/NEWS.md#from-217-to-218

basil-conto commented 3 years ago

Ping.

iyefrat commented 2 years ago

Pong.

alphapapa commented 2 years ago

Thanks for the patch, and sorry for overlooking it.

AtomicNess123 commented 1 year ago

I'm still getting:

In toplevel form:
org-sidebar.el:74:1:Warning: Package dash-functional is obsolete; use dash
    2.18.0 instead

In toplevel form:
org-sidebar.el:74:1:Warning: Package dash-functional is obsolete; use dash
    2.18.0 instead

Has the dependency being removed?

basil-conto commented 1 year ago

I'm still getting:

This shouldn't be happening, at least not due to org-sidebar. Have you tried updating/reinstalling these/all packages? Perhaps you have an old version of org-sidebar installed?

Has the dependency being removed?

Yes, as of this PR being merged, org-sidebar no longer depends on dash-functional.

AtomicNess123 commented 1 year ago

Yes, all in order now. Thanks!