search

alphapapa / org-super-agenda

Supercharge your Org daily/weekly agenda by grouping items
GNU General Public License v3.0
1.35k stars 107 forks source link

Removed check for 'dotime in time-grid. #221

Open tuh8888 opened 2 years ago

tuh8888 commented 2 years ago

Possible fix for #212

Might be a naive solution, but I'm not sure what the check for 'dotime is supposed to account for. This solved the issue for my configuration and use-case. I'm not sure how your testing framework works in order to see if I've messed anything else up that you've already thought of though.

alphapapa commented 2 years ago

Well, as you can see from the removed comment, that code was added by necessity after much research and testing of the org-agenda code's output. While removing it might fix the TODO search in your case, it would probably also break other agenda/search types, which is the main use case for this package. I couldn't merge this unless it could be confirmed that 1) Org has changed something and doesn't use this text property anymore, and 2) the Org version in which such a change happened is the minimum supported by this package (which wouldn't be likely to happen for some time).

tuh8888 commented 2 years ago

Unfortunately, I don't know what testing you've done to be able to tell when you needed the dotime check. Maybe another org-super-agenda--defgroup could be added which doesn't include the dotime check of time-grid? I spent a long time trying to figure out how to get around time-grid's greediness, thinking I was misunderstanding something about its behavior or the query language, before implementing this fix. At least some documentation that this is a potential pitfall might be nice if you understandably don't want to potentially break time-grid's functionality for users of older versions of org-agenda.

On another note, I really appreciate the work you've put into this package, and it fits heavily into my daily workflow. I apologize for not being able to offer a more nuanced solution to this problem you obviously spent a while considering already. Maybe some day I'll be able to take the time to examine org-agenda's usage of the dotime property to figure out a better solution for this issue.

alphapapa commented 1 year ago

Fixing this will require some research and testing to confirm that nothing else gets broken.

In the meantime, I can recommend using org-ql as an alternative to using the Org Agenda "all TODOs" view.

@tuh8888 Thanks for the kind words.