search

alphapapa / org-super-agenda

Supercharge your Org daily/weekly agenda by grouping items
GNU General Public License v3.0
1.38k stars 108 forks source link

defcustom: org-super-agenda-ignored-agenda-names #234

Closed pedrormjunior closed 1 year ago

pedrormjunior commented 2 years ago

List of agenda names on which to avoid using Org Super Agenda. The agenda name is as specified by the local variable org-agenda-name of the agenda to be ignored by Org Super Agenda.

The function org-super-agenda--filter-finalize-entries was modified in order to not finalize the entries of the agenda when the agenda being processed match one of the strings defined in the custom variable org-super-agenda-ignored-agenda-names defined by this commit.

Example:

(custom-set-variables
 '(org-super-agenda-ignored-agenda-names
   '("^TAGS" "^SEARCH$" "^TODO$")))

This solves the closed issue #19 in a seemingly more straightforward and permanent way.

alphapapa commented 2 years ago

Bom dia Pedro,

This solves the closed issue #19 in a seemingly more straightforward and permanent way.

Thanks for this PR, but I don't think this is necessary, since the solution in #19 is so simple and idiomatic. It would add complexity to this package to solve an issue that's outside of its scope. Adding more options and paths in the code should generally be avoided.

pedrormjunior commented 1 year ago

Olá alphapapa, got it, thanks. I realized that, in fact, it is a more appropriate solution, more idiomatic, as you mentioned. I implemented it here and it is expected to work nicely for my use case. I noticed that, with this solution, the variable org-super-agenda-groups becomes somehow obsolete, as it needs to be nil for this solution to work, right? Furthermore, it is declared with defcustom, that might make a beginner user of the package confused. Would it be nice to mention this in the README? I just checked that the "example" presented in the README contradicts the solution in #19, as it indicates to set the variable org-super-agenda-groups. That is, one that is following the README will not be able to get issue #19 solved.

alphapapa commented 1 year ago

@pedrormjunior I'm sorry but I'm not sure what you mean. But if you have any specific suggestions for updates to the documentation, please open an issue for them. Thanks.