search

alphapapa / org-super-agenda

Supercharge your Org daily/weekly agenda by grouping items
GNU General Public License v3.0
1.33k stars 107 forks source link

Fix: resolve invalid `group-dispatch-take` `group` parameter definition #248

Closed natejlong closed 9 months ago

natejlong commented 9 months ago

Fixes https://github.com/alphapapa/org-super-agenda/issues/216

Previously, using :take was throwing "Invalid org-super-agenda-groups-selector" errors when used with valid syntax. This fixes that so :take works as intended.

The cause/solution is described by @cashpw in the linked issue:

I think it's the &rest that's causing it. The group variable appears to be wrapped by an extra set of parenthesis in my debug window (eg: ((:tag "concept")) rather than (:tag "concept")). I suspect &rest is adding this to make group into a list.

I've been using this change locally for a few months successfully, but have not done any more rigorous testing.

Just wanted to make a PR to summarize the fix from that issue and make it easy to roll out if this is indeed the correct change to make; feel free to change/remove/supersede this PR as you see fit!

alphapapa commented 9 months ago

Thanks, I'll merge this soon.