alphapapa / org-web-tools

View, capture, and archive Web pages in Org-mode
GNU General Public License v3.0
635 stars 33 forks source link

org-element-at-point and w3m error #61

Open OrionRandD opened 10 months ago

OrionRandD commented 10 months ago

I am getting this error now after an Emacs update...

Error running timer ‘org-reveal’: (error "‘org-element-at-point’ cannot be used in non-Org buffer #<buffer w3m> (w3m-mode)") [2 times]

It happens when I am in a w3m buffer, trying to capture it... with the command: C-c c then: w

I hadn't had such an error in the past...

alphapapa commented 10 months ago

This is more fallout from a backwards-incompatible change in Org 9.7.

@yantar92 I understand why this change was made, but perhaps it was a bit premature, given how much breakage it's causing downstream? It would seem appropriate to at least make it a warning for a full major version before making it an error, to give downstream devs and users a break.

yantar92 commented 10 months ago

Adam Porter @.***> writes:

@yantar92 I understand why this change was made, but perhaps it was a bit premature, given how much breakage it's causing downstream? It would seem appropriate to at least make it a warning for a full major version before making it an error, to give downstream devs and users a break.

I tend to agree. I hope that having an error thrown have sufficiently reduced the number of bugs reported to Org due to such incorrect usage.

I now demoted the error to warning: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fac55324accbcab08dfebbde8295b2f1b4b9f45e

-- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92

alphapapa commented 10 months ago

@yantar92 Thank you.