search

alphapapa / outshine

Org-mode for non-Org buffers
GNU General Public License v2.0
212 stars 23 forks source link

Don't unnecessarily override the input-decode-map in graphical Emacs #51

Closed CeleritasCelery closed 5 years ago

CeleritasCelery commented 5 years ago

This is a horrible hack to get M-up and M-down to work in the terminal. We don't need it in graphical Emacs and it can cause problems if the users is already trying to override the input-decode-map to distinguish <esc> and C-[.

alphapapa commented 5 years ago

Thanks, Troy. I'm inclined to simply remove this completely, like I said in the FIXME. I understand how it can be useful for terminal users, but I think it doesn't belong in the package. I think it would make more sense to put it in the documentation and let users who need it add the code to their config.

@thblt What do you think?

CeleritasCelery commented 5 years ago

I think it would be best to remove it as well. If that is what you want I can update the PR.

thblt commented 5 years ago

Hey sorry, I may have missed the notification on this one. I agree with complete removal, since the issue this code fixes is way outside of Outshine. https://github.com/alphapapa/outshine/commit/210cc88bf9ee2fca2a283e4de89d4abe849d706b did it, I'm adding a note to the documentation.