search

alphapapa / outshine

Org-mode for non-Org buffers
GNU General Public License v2.0
212 stars 23 forks source link

Quick fix of #75 #80

Open yuhan0 opened 4 years ago

yuhan0 commented 4 years ago

This PR drops an obsolete workaround for remapping keys and fixes #75 by wrapping the offending code in a (when outshine-use-speed-commands ) block.

The consequence of this is that outshine-use-speed-commands (nil by default) has to be enabled before the package is loaded, and changing it afterwards does not have any effect.

alphapapa commented 4 years ago

Thanks. However, the consequence you mention is an important one. The idiomatic way to fix this would be to define an outshine-speed-commands-mode minor mode.

yuhan0 commented 4 years ago

I'm aware of this, which is why it's labeled a "quick fix". Feel free to only merge the first 2 commits or implement the additional minor mode afterwards, or just leave this here for others to reference in their own forks.

The current code as I recall is incompatible with multiple-cursors and other packages which rely on self-insert-command.

Note that other packages like Evil and outline-minor mode itself also have similar caveats with vars that must be set before package load.