alphapapa / pocket-reader.el

Emacs client for Pocket reading list (getpocket.com)
GNU General Public License v3.0
223 stars 12 forks source link

Tags containing spaces not working #43

Closed pataquets closed 1 year ago

pataquets commented 1 year ago

I have several items tagged view online and I can't search them using pocket-reader-search. Looking at the code, query is split just by spaces alone, without any parsing for space-containing tags. Possible solutions:

alphapapa commented 1 year ago

Thanks, this should be fixed, indeed. I don't know how soon I'll have time to work on this, so patches welcome.

pataquets commented 1 year ago

Glad to hear it, thank you. Unfortunately, still novice Elisp'er here. However, any directions on your preferred approach (UX and code-wise) and other advice you may provide will be appreciated and, maybe in the future it could be useful for me or others going thru this issue and ready to pick it up. I've seen a handful of functions in the code needing love, which suggests me the issue should be broken in parts to qualify as "low hanging fruit" / "good first issue".

alphapapa commented 1 year ago

Glad to hear it, thank you. Unfortunately, still novice Elisp'er here. However, any directions on your preferred approach (UX and code-wise) and other advice you may provide will be appreciated and, maybe in the future it could be useful for me or others going thru this issue and ready to pick it up.

I don't have much advice about this. It should be relatively simple to parse the string given by the user for any segments enclosed in quotes. Since the syntax is basically Lisp syntax, you can probably use the READ function.

I've seen a handful of functions in the code needing love, which suggests me the issue should be broken in parts to qualify as "low hanging fruit" / "good first issue".

You'd have to be more specific about which functions you mean.

alphapapa commented 1 year ago

@pataquets This should be fixed now. Please let me know if it works for you.

pataquets commented 1 year ago

@alphapapa Tested. function works OK, thanks! Filed related issue: #46.