search

alphapapa / pocket-reader.el

Emacs client for Pocket reading list (getpocket.com)
GNU General Public License v3.0
223 stars 12 forks source link

Running pocket-reader on Emacs 29.3 errors with a void symbol #50

Closed AleksandarMicovic closed 6 months ago

AleksandarMicovic commented 6 months ago

Steps to reproduce

  1. Install pocket-reader from MELPA.
  2. Run pocket-reader per README.
  3. Receive error Symbol's value as variable is void: auto-revert-notify-watch-descriptor-hash-list

Expected result

  1. I'm actually not sure as I've never run the package :) but I assume it's supposed to ask for authentication?

Let me know if I can do anything else to debug, or if there's an interim workaround.

alphapapa commented 6 months ago

Please note that the symbol auto-revert-notify-watch-descriptor-hash-list is not present in this package's source code. As well, I use this package on Emacs 29.3 without any problem. Therefore there must be a problem in your Emacs configuration or in another package you have installed. I'd recommend testing in a clean configuration with https://github.com/alphapapa/with-emacs.sh

AleksandarMicovic commented 6 months ago

This actually seems to affect all packages using request, of which pocket-reader relies on as a dependency.

I wanted to follow up here just in case anyone else runs into this. You can fix the issue by manually applying this commit to request. There's a small conversation about this here.

Thanks @alphapapa for the testing script. Led me down this rabbit hole.

alphapapa commented 6 months ago

@AleksandarMicovic Ah, an unfortunate situation. I guess you're using MELPA Stable in your config? This sort of thing is one of the reasons it's not generally recommended to use MELPA Stable. I remember now seeing that workaround in request and being puzzled by it.

Anyway, I guess I should switch pocket-lib to use plz at this point.