Closed jgkamat closed 6 years ago
I'm overloading this to fix some PR link colors as well:
Before:
After:
Hey @jgkamat! 😆
This fixes at least some of the issues I mentioned in #5 🎉
Might as well keep going then! :D
Before:
After:
Before:
After:
Hi Jay,
Thank you very much, this looks great! I made a few comments about minor changes to make it a bit more idiomatic. If you don't mind making those, I'll be glad to merge this right away!
One visual note: I like that you made the "Open"/"Closed" text more visible on the colored backgrounds in the issue labels. Did you try using white instead of black? I wonder if that might look more consistent with the overall theme. Let me know what you think.
Also, on the yellow icon next to "Changes approved", could you make the icon white against the yellow background? The contrast is kind of weak by default. :)
Sorry about all the problems, this is my first time working with css, so I guess that's to be expected :P
Let me know if you spot anything else wrong
Did you try using white instead of black? I wonder if that might look more consistent with the overall theme. Let me know what you think.
I agree, white does look better, I'll switch it
Also, on the yellow icon next to "Changes approved", could you make the icon white against the yellow background?
Done! :)
Sorry about all the problems, this is my first time working with css, so I guess that's to be expected :P
Not at all! You did a great job. I'm very impressed for this being your first time working with CSS, I'd never have guessed, especially with your learning Stylus at the same time! Stylus is powerful but so concise that it can be confusing and require some trial-and-error to figure out.
Thank you very much, and please feel free to submit more PRs in the future!
Like before, please regenerate the CSS for me, I don't think I have node set up correctly.
Before:
After: