search

alphapapa / solarized-everything-css

A collection of Solarized user-stylesheets for...everything?
GNU General Public License v3.0
278 stars 43 forks source link

Add reveal.js site specific quirk #21

Closed jgkamat closed 6 years ago

jgkamat commented 6 years ago

Hi, I recently discovered that with solarized-everything-css, reveal css has black text on a dark background (hard to read), so I added a site specific quirk.

This brings up a larger question though, for tiny changes such as this, should these go in a 'quirks.styl' file, or in their own site files? I would imaging 'quirks.styl' would contain very simple changes like this one (with no chance of conflicting on other sites).

What are your thoughts about it? (probably need to decide that before this is merged).

alphapapa commented 6 years ago

Well, I'm not sure about this. reveal.js presentations can be hosted on any site (or locally), and the reveal CSS class could be used on any site, so there's no way to isolate this to reveal.js presentations. If we apply this to all sites that use the reveal class, it could cause conflicts. It seems like the best way to apply Solarized to reveal.js would be to do so within reveal.js. Does it support themes or custom CSS?

jgkamat commented 6 years ago

Hmm, I hadn't thought about it that way. 'reveal' is a generic enough keyword that it's probably on a bunch of random sites, so I agree with you. Because of the probablility of conflicts, I'll close this.

There are custom themes, but the idea of this is that we could get solarized themes on every reveal presentation (rather than the theme the creator decided).

alphapapa commented 6 years ago

There are custom themes, but the idea of this is that we could get solarized themes on every reveal presentation (rather than the theme the creator decided).

Hm. I'm not sure that's a good idea, to be honest. :) But if you view a lot of reveal presentations on your system, you can add a simple rule like that to a global user stylesheet in your own browser.