Closed jgkamat closed 6 years ago
Hey Jay,
Thanks very much for fixing these!
I set images to be slightly transparent so that they aren't so bright and contrasty, especially on Solarized Dark. I'd kind of like to keep them that way, unless it's very unpopular. I think it gives a unique feel, kind of subdued and relaxing, which goes with the theme. But I don't feel super strong about it, so if people don't like it, we can remove it. What do you think?
FWIW I'm still not sure what to think about the image change. I'm glad they don't shine as bright as they do without, but at the same time I never really got used to them looking how they do 😆
@The-Compiler Haha, yeah, I never knew what anyone else thought about it. Of course, I didn't think very many people were using the stylesheet, anyway. :)
What do you think about making them 25% transparent instead of 50% like they are now?
I'm going to merge this into multi-theme
as well now, thats good with you @alphapapa, right? :)
Yes, please do. Thanks.
Hi, I've gone and made a few more github fixes.
+
and-
colors in code block comments don't have a white background anymoreFixed some messages being dark in PR history
![2017-11-14-012032_595x75_scrot](https://user-images.githubusercontent.com/4349709/32765767-0e177092-c8da-11e7-9258-cf7d6d845d9d.png)
[possibly contoversial] I upgraded my browser and I noticed github profile pictures are a bit dark. Is there a reason for them dimmed? I added a commit that turned that off.![2017-11-14-010714_662x433_scrot](https://user-images.githubusercontent.com/4349709/32765648-67656de4-c8d9-11e7-9dc8-4c0de6d479d9.png)
Fix branch popups (might need a bit more work, but this is a lot better than before)![2017-11-14-010732_353x298_scrot](https://user-images.githubusercontent.com/4349709/32765649-67734ca2-c8d9-11e7-95a7-95509b5e77a4.png)
Fix signed commit popups![2017-11-14-011240_382x333_scrot](https://user-images.githubusercontent.com/4349709/32765650-6780e9a2-c8d9-11e7-8669-015d3ef4f6c3.png)
Let me know if you see any issues! :smile:
This should be very easy to merge into
multi-theme
as it's only touching styl files.