alphapapa / solarized-everything-css

A collection of Solarized user-stylesheets for...everything?
GNU General Public License v3.0
278 stars 43 forks source link

Github Fixes Part 3 #32

Closed jgkamat closed 6 years ago

jgkamat commented 6 years ago

Hi, I've gone and made a few more github fixes.

Let me know if you see any issues! :smile:

This should be very easy to merge into multi-theme as it's only touching styl files.

alphapapa commented 6 years ago

Hey Jay,

Thanks very much for fixing these!

I set images to be slightly transparent so that they aren't so bright and contrasty, especially on Solarized Dark. I'd kind of like to keep them that way, unless it's very unpopular. I think it gives a unique feel, kind of subdued and relaxing, which goes with the theme. But I don't feel super strong about it, so if people don't like it, we can remove it. What do you think?

The-Compiler commented 6 years ago

FWIW I'm still not sure what to think about the image change. I'm glad they don't shine as bright as they do without, but at the same time I never really got used to them looking how they do 😆

alphapapa commented 6 years ago

@The-Compiler Haha, yeah, I never knew what anyone else thought about it. Of course, I didn't think very many people were using the stylesheet, anyway. :)

What do you think about making them 25% transparent instead of 50% like they are now?

jgkamat commented 6 years ago

I'm going to merge this into multi-theme as well now, thats good with you @alphapapa, right? :)

alphapapa commented 6 years ago

Yes, please do. Thanks.