search

alphapapa / solarized-everything-css

A collection of Solarized user-stylesheets for...everything?
GNU General Public License v3.0
278 stars 43 forks source link

Need exclusion mechanism in build system for all-sites sheets #37

Closed non-Jedi closed 6 years ago

non-Jedi commented 6 years ago

Using qutebrowser with solarized-dark-all-sites.css, reddit looks like this:

solarized-reddit-weird

I'm not great with web-stuff, so it's very possible this is just something I've somehow screwed up myself. Can anyone else reproduce?

The-Compiler commented 6 years ago

Huh, that sure is weird! I can't reproduce FWIW.

non-Jedi commented 6 years ago

qutebrowser version info fwiw:

qutebrowser v1.1.2
Git commit: 
Backend: QtWebEngine (Chromium 61.0.3163.140)

CPython: 3.6.4
Qt: 5.10.1
PyQt: 5.8.2

sip: 4.19.7
colorama: no
pypeg2: 2.15
jinja2: 2.10
pygments: 2.2.0
yaml: 3.12
cssutils: no
attr: 17.4.0
PyQt5.QtWebEngineWidgets: yes
PyQt5.QtWebKitWidgets: no
pdf.js: no
sqlite: 3.22.0
QtNetwork SSL: LibreSSL 2.6.4

Style: QFusionStyle
Platform: Linux-4.14.26_1-x86_64-with-glibc2.3.4, 64bit
Linux distribution: void (void)
Frozen: False
Imported from /usr/lib/python3.6/site-packages/qutebrowser
Qt library executable path: /usr/lib/qt5/libexec, data path: /usr/share/qt5

Paths:
cache: /home/adam/.cache/qutebrowser
config: /home/adam/.config/qutebrowser
data: /home/adam/.local/share/qutebrowser
runtime: /run/user/1000/qutebrowser

Uptime: 5:25:10
non-Jedi commented 6 years ago

Ah. It's specific to the multi-theme branch. Just checked out master, and everything works fine. Can anyone reproduce on multi-theme?

alphapapa commented 6 years ago

In general, the all-sites.css files are not guaranteed nor even expected to work well. They are a mashup of all the sites' stylesheets into one file. When possible you should use site-specific files, and if problems arise then, file a bug against specific stylesheets.

non-Jedi commented 6 years ago

Looks like qutebrowser 1.2 is out now, so that's now actually actionable. @alphapapa should I close as wontfix?

jgkamat commented 6 years ago

@non-Jedi by the way, I remove the bigblow stylesheet (since it seems to be the main offender to the all-sites working well). Without the bigblow stylesheet, it works great for me on all the sites that I frequent (and I personally keep it that way for simplicity).

The reason that this is an issue on multi-theme is that the bigblow stylesheet was removed on master (and re-added on multi-theme).

(see #18)

alphapapa commented 6 years ago

I guess what we need is a modification to the build script to exclude certain styles from the all-sites file. I hesitate to add the extra configuration and complexity, but if it really does make the difference between that file being useful or not, it seems like the right thing to do.

@non-Jedi I think I will repurpose this issue for that idea. No promises as to when it may be implemented, but at least you have a workaround until then. :)