alphapapa / solarized-everything-css

A collection of Solarized user-stylesheets for...everything?
GNU General Public License v3.0
278 stars 43 forks source link

fix the invisible dark text color #47

Open vcfvct opened 5 years ago

vcfvct commented 5 years ago

The pl-s1 and pl-sr is cause invisible issue in javascript and typescript code.

pl-s1-before

pl-s1-before

pl-sr-before

pl-sr-before

After the fix:

pl-s1-after

pl-s1-after

pl-sr-after

pl-sr-after

Please let me know if you have any concerns.

jgkamat commented 5 years ago

LGTM :)

alphapapa commented 5 years ago

That does make them visible again, but are they intended to be a different color? Should we use a different color than the color used for strings?

alphapapa commented 3 years ago

@vcfvct Why did you close this PR? Is it still applicable?