search

alphapapa / solarized-everything-css

A collection of Solarized user-stylesheets for...everything?
GNU General Public License v3.0
278 stars 43 forks source link

sites: Add support for readthedocs.io #57

Open Holzhaus opened 5 years ago

Holzhaus commented 5 years ago

Add some fixes for readthedocs.io.

Screenshots (Gruvbox):

Before After

alphapapa commented 5 years ago

Hi Jan,

Thanks also for this PR. A few notes:

  1. In the screenshot, could you improve the contrast of the Configuration File line in the nav sidebar?
  2. Below that, the Version 2 and Version 1 are the same background color as the rest of the sidebar. Is that how it is in the default RtD theme, or should those sub-headings have a different background color? Not that we have to follow it exactly, just a thought.
  3. The CSS selectors are very specific and verbose. This isn't necessarily bad, but it might be preferable to make them as simple as possible. For example, instead of .rst-content .wy-alert-info.admonition .wy-alert-title, would .wy-alert-title be sufficient?
  4. I also made a line review comment about a possible missing comma.

Thanks.