alphaparrot / ExoPlaSim

Exoplanet Planet Simulator (PlaSim extended for different planet types (including tidally-locked) and evolution on geological timescales--glaciers and carbon cycle)
GNU General Public License v2.0
53 stars 13 forks source link

Final latitude of MYPID=NROOT thread has undamped divergence in top model layer #26

Closed alphaparrot closed 1 month ago

alphaparrot commented 1 month ago

https://github.com/alphaparrot/ExoPlaSim/assets/14878016/0b5fe9b1-919e-4fdc-b69c-8a12b1f91079

tost_topdivergence_t85_130

Models show a band of longitudinally-oscillating divergence in the top layer of the atmosphere in the southernmost latitude of the root thread (MYPID=NROOT). This then propagates to the rest of the model and imprints on physical features. This occurs irrespective of land configuration or filter choice, and is most evident in extremely slow rotators. Most likely something is running to N-1 instead of N, or NHOR is computed incorrectly for MYPID=NROOT. It may also be that TOA hyperdiffusion and/or damping are not being properly applied in the root thread. The code should be carefully reviewed to see where there may be a mistake.

alphaparrot commented 1 month ago

Fixed in commit #983e181