alphaqu / DashLoader

Launch Minecraft at the speed of light.
GNU Lesser General Public License v3.0
95 stars 21 forks source link

dash loader incorrectly caching display value of a child model #19

Closed walksanatora closed 2 years ago

walksanatora commented 2 years ago

Describe the bug A clear and concise description of what the bug is. earlier I was working on a data pack and i had the following json

{
    "parent":"gun:item/awp",
    "display": {
        "firstperson_righthand": {
            "rotation": [0, 0, 0],
            "translation": [-10.1, 14, 5.614],
            "scale": [1, 1, 0.7]
        },
        "firstperson_lefthand": {
            "rotation": [0, 0, 0],
            "translation": [-8, 14, 5.614],
            "scale": [1, 1, 0.7]
        }
    }
}

In vanilla minecraft the model is placed in the top middle of the screen when using fabric with dash loader the model is placed in the top right (the position of the parent model)

To Reproduce Steps to reproduce the behavior:

  1. create a model
  2. create a child model and change it's display properties
  3. child does not have updated display properties

Expected behavior model is placed in proper location

Context (please complete the following information):

alphaqu commented 2 years ago

Hi there! Can you please provide full logs when this happened?

alphaqu commented 2 years ago

Should be fixed in the next release.