search

alphaqu / DashLoader

Launch Minecraft at the speed of light.
GNU Lesser General Public License v3.0
95 stars 21 forks source link

MoreCulling incompatability #29

Closed Phoenix-Starlight closed 1 year ago

Phoenix-Starlight commented 2 years ago

Describe the bug Sodium currently is broken, and renders in a way similar to xray. (Walls are absolutely transparent) To Reproduce Steps to reproduce the behavior:

  1. Go to any world

Expected behavior Not be xray-like and transparent

Context (please complete the following information):

Full Logs latest.log

Additional Context If Dashloader fails (F3+T) then everything behaves as normal.

alphaqu commented 2 years ago

Can you please isolate the issue? Sodium with DashLoader does not cause an incompatibility by my testing. This may be a different mod being incompatible or a 3 way incompatibility.

AreaDenial commented 2 years ago

I'm having an issue like this occur as well, I thought it was another mod at first but it seems Dashloader may be the culprit. These same chunks always become invisible after some time passes (perhaps when they're reloaded?). Exiting and reloading the world doesn't fix it, but pressing F3+T (clearing DashLoader's cache) does. Will do some testing later to try to isolate the issue, it might be completely unrelated to Sodium for all I know. chunks_normal chunks_broken

alphaqu commented 2 years ago

My guess would be that this is a three way incompatibility with some stupid mod

Phoenix-Starlight commented 2 years ago

It may or may not be 4 way...

Phoenix-Starlight commented 2 years ago

This issue is invalid and closable. It appears to be that I forgot Indium, which makes fabric rendering api, sodium and other mods that utilize it work properly.

On 9/4/22, Yan Chubikov @.***> wrote:

My guess would be that this is a three way incompatibility with some stupid mod

-- Reply to this email directly or view it on GitHub: https://github.com/TeamQuantumFusion/DashLoader/issues/29#issuecomment-1236294855 You are receiving this because you authored the thread.

Message ID: @.***>

Phoenix-Starlight commented 2 years ago

I am forced to take what I said back because it happened again.

Benonardo commented 2 years ago

Also happened to me, especially on servers. It probably is a 3 way issue, but removing DashLoader has the least gameplay impact for now, so I am going to this. (The issue started to happen in 1.19.1)

Phoenix-Starlight commented 2 years ago

Not 3 way issue. 4 or 5 way issue. (Do resource packs count?)

Mods used: Sodium MoreCulling Continuity Fabric API Indium Dashloader

Resourcepacks used: 3D Redstone tweaks (requires Continuity and utilizes emissives) here AquaHUD here Log: latest.log Reproduction steps:

  1. Launch
  2. Load resource packs in
  3. Quit and re-launch. (So dashloader uses the cache)
  4. Go to any world.
PweSol commented 2 years ago

I did mention this a long time ago here https://github.com/TeamQuantumFusion/DashLoader/pull/25#issuecomment-1201505842 but it seems like it was ignored. I'm running a plethora of performance mods as well, so it's most likely an incompatibility with some mod combination.

Alexander020304 commented 1 year ago

I been having a similar issue. 2022-11-01_16 57 12 latest.log

AetherYT commented 1 year ago

Also happened to me, especially on servers. It probably is a 3 way issue, but removing DashLoader has the least gameplay impact for now, so I am going to this. (The issue started to happen in 1.19.1)

Dude, it is because of MoreCulling and DashLoader. F3 + T fixes it (temporarily??)

Phoenix-Starlight commented 1 year ago

It only fixes because dashloader fails, so there is no 'boost' by dashloader. Also it'll fail when dashloader naively allocates all content causing OOM. Not really a good solution, per se.

On 11/21/22, Vidhun Nagarajan @.***> wrote:

Also happened to me, especially on servers. It probably is a 3 way issue, but removing DashLoader has the least gameplay impact for now, so I am going to this. (The issue started to happen in 1.19.1)

Dude, it is because of MoreCulling and DashLoader. F3 + T fixes it (temporarily??)

-- Reply to this email directly or view it on GitHub: https://github.com/TeamQuantumFusion/DashLoader/issues/29#issuecomment-1322134547 You are receiving this because you authored the thread.

Message ID: @.***>

AreaDenial commented 1 year ago

It definitely has to do with MoreCulling. The issue is fixed when I disable MoreCulling's "BlockState Culling" option, and when the option is re-enabled, the exact same invisible blocks become bugged again.

FxMorin commented 1 year ago

It's due to DashLoader somehow removing a final field from MultipartBakedModel. I didn't even think that would be possible without ASM. If dashloader is some how removing that field, it may be doing it in other mods like Lithium. Causing it to recache the entire entity lists every time. MultipartBakedModel_cacheMixin This being missing should be impossible