search

alphaqu / DashLoader

Launch Minecraft at the speed of light.
GNU Lesser General Public License v3.0
95 stars 21 forks source link

DashLoader is not compatible with Modern Font Pack #32

Open YutaYamamoto212 opened 1 year ago

YutaYamamoto212 commented 1 year ago

Describe the bug Modern Font Pack modernizes the font of Minecraft and make it smooth and beautiful. However, the HD version or the Supreme version is not compatible with DashLoader. It drastically increases game load times and causes DashLoader to crash.

To Reproduce Steps to reproduce the behavior:

  1. Click HERE to go to the Modern Font Pack CurseForge page.
  2. Click the Files tab.
  3. Download any of the following resource packs: 
    modern_font_pack_je_hd_jp_v919.zip
modern_font_pack_je_hd_kr_v919.zip
modern_font_pack_je_hd_cn_v919.zip
modern_font_pack_je_hd_tw_v919.zip
modern_font_pack_je_hd_hk_v919.zip
modern_font_pack_je_supreme_jp_v919.zip
modern_font_pack_je_supreme_kr_v919.zip
modern_font_pack_je_supreme_cn_v919.zip
modern_font_pack_je_supreme_tw_v919.zip
modern_font_pack_je_supreme_hk_v919.zip
  4. Install any of the above resource packs into the game.
  5. Apply the resource pack, then the error occurred. Restart the game, the error still exists.

Expected behavior DashLoader can cache this resource pack normally.

Screenshots image

Context (please complete the following information):

Full Logs After applying the resource pack: https://mclo.gs/GK8arM5 After restarting the game: https://mclo.gs/cRK0d8K

Additional context Sometimes there is an out of memory error when caching this resource pack. Allocating 8 GB or more of memory will not give an out of memory error, but will give another error java.lang.IllegalArgumentException: capacity < 0: (-1159001911 < 0). The Basic version (modern_font_pack_je_basic_jp_v919.zip, modern_font_pack_je_basic_kr_v919.zip, modern_font_pack_je_basic_cn_v919.zip, modern_font_pack_je_basic_tw_v919.zip and modern_font_pack_je_basic_hk_v919.zip) of the resource pack does not have this problem.

yavko commented 1 year ago

Describe the bug Modern Font Pack modernizes the font of Minecraft and make it smooth and beautiful. However, the HD version or the Supreme version is not compatible with DashLoader. It drastically increases game load times and causes DashLoader to crash.

To Reproduce Steps to reproduce the behavior:

1. Click [HERE](https://www.curseforge.com/minecraft/texture-packs/modern-font-pack) to go to the Modern Font Pack CurseForge page.

2. Click the Files tab.

3. Download any of the following resource packs:
modern_font_pack_je_hd_jp_v919.zip
modern_font_pack_je_hd_kr_v919.zip
modern_font_pack_je_hd_cn_v919.zip
modern_font_pack_je_hd_tw_v919.zip
modern_font_pack_je_hd_hk_v919.zip
modern_font_pack_je_supreme_jp_v919.zip
modern_font_pack_je_supreme_kr_v919.zip
modern_font_pack_je_supreme_cn_v919.zip
modern_font_pack_je_supreme_tw_v919.zip
modern_font_pack_je_supreme_hk_v919.zip
4. Install any of the above resource packs into the game.

5. Apply the resource pack, then the error occurred. Restart the game, the error still exists.

Expected behavior DashLoader can cache this resource pack normally.

Screenshots image

Context (please complete the following information):

* DashLoader Version 4.1.3

* Minecraft Version 1.19.2

Full Logs After applying the resource pack: mclo.gs/GK8arM5 After restarting the game: mclo.gs/cRK0d8K

Additional context Sometimes there is an out of memory error when caching this resource pack. Allocating 8 GB or more of memory will not give an out of memory error, but will give another error java.lang.IllegalArgumentException: capacity < 0: (-1159001911 < 0). The Basic version (modern_font_pack_je_basic_jp_v919.zip, modern_font_pack_je_basic_kr_v919.zip, modern_font_pack_je_basic_cn_v919.zip, modern_font_pack_je_basic_tw_v919.zip and modern_font_pack_je_basic_hk_v919.zip) of the resource pack does not have this problem.

I also had this issue

alphaqu commented 1 year ago

Hi, this should be fixed in the 5.0 release which is available on our discord server right now.