search

alphaqu / DashLoader

Launch Minecraft at the speed of light.
GNU Lesser General Public License v3.0
93 stars 21 forks source link

Incompatibility with Enhanced Block Entities #44

Open rayzchen opened 1 year ago

rayzchen commented 1 year ago

Describe the bug A clear and concise description of what the bug is. Game crashes with Enhanced Block Entities and Dashloader in the mods folder.

To Reproduce Steps to reproduce the behavior:

  1. Install fabric
  2. Install the two mods
  3. Launch minecraft
  4. Error log

Expected behavior A clear and concise description of what you expected to happen. No error

Screenshots If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

Full Logs Please always provide your entire minecraft logs when you report an issue to dashloader. Upload them to sites like pastebin.com or paste.gg and then put the link here. https://paste.gg/p/anonymous/550cebee77764ed4964f3ed1f24fb60d

Additional context Add any other context about the problem here. Didnt work with 1.19.2 but I don't remember the mod versions.

PweSol commented 1 year ago

I've been running EBE and DashLoader since forever and have never experienced a crash related to the combination of these two mods.

Minecraft Version [e.g. 1.18.1] 1.19.3

But you do mention your Minecraft version to be 1.19.3, and EBE is currently incompatible with that version. You need to wait for EBE to get updated. Also DashLoader v4.1.3 might not be compatible with 1.19.3 as well, where as the 5.0 version is.

alphaqu commented 1 year ago

Hi there, DashLoader 4.1.3 does not support Minecraft 1.19.3, if you want DashLoader on 1.19.3 you can download the experimental 5.0 versions.

rayzchen commented 1 year ago

Funny, it launched fine with a few mods so I just assumed it was compatible. Why does 1.19.3, a minor version change, have to be so incompatible...

Taken from https://semver.org/:

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes
  2. MINOR version when you add functionality in a backwards compatible manner
  3. PATCH version when you make backwards compatible bug fixes

I guess Minecraft doesn't support SemVer then

alphaqu commented 1 year ago

Its more that dashloader got a MAJOR change, not minecraft

rayzchen commented 1 year ago

Ah, didn't know that. Though I was referring more to lots of other mods crashing really badly even though they said 1.19.x

MissPotato commented 1 year ago

Off topic but want to clarify misinformation: the changes to 1.19.3 are minor from the perspective of a vanilla player. The changes in question included in 1.19.3 are a bunch of under the hood changes. These changes are very incompatible with mods because of it. I agree that Mojang should have waited till 1.20.0 to release the changes, but historically that hasn't been a consistent process by them.

From the perspective of a modded player, a lot of devs have decided the amount of work required to update to 1.19.3 outweighs the gains of 1.19.3. Especially considering a lot of the changes in 1.19.3 are future proofing and bedrock <-> java parity.

rayzchen commented 1 year ago

I also found that out when I did some further reading. I'm not a mod developer, but wouldn't it be better to start working on a 1.19.3 update so that the jump to 1.20 isn't as huge? The features of 1.19.3 should be included in 1.20, unless Minecraft makes a complete rewrite.