alphaqu / DashLoader

Launch Minecraft at the speed of light.
GNU Lesser General Public License v3.0
93 stars 21 forks source link

[LAUNCH]: Imcompatibility with Sodium 0.5 #63

Open NalCol opened 1 year ago

NalCol commented 1 year ago

Version

5.0.0-alpha.14

Minecraft Version

1.19.4

Entire Logs

https://mclo.gs/DbhBsF6

Additional Notes

I have many mods installed (mostly optimization mods) and it will crash only with Sodium and Iris is enabled. IDK if the problem is being produced under the specific mod list or just iris compatibility problem.

NalCol commented 1 year ago

I found the problem. It is just the newest Sodium Beta 0.4.11 broke everything, including Iris, DashLoader etc. Use Sodium 0.4.10 and Sodium Extra 0.4.18 will be fine with DashLoader. I think the Sodium update will break a lot of mods in the future including DashLoader so I will keep this issue open.

CassieRoseZA commented 1 year ago

it seems to have broken w/ Sodium 0.5 Release

theRookieCoder commented 1 year ago

No idea what happened in the 0.4.11 beta, but in 0.5.0 they changed the location of a mixin class without changing the corresponding feature name. Dashloader happens to make use of that feature flag and the mistake ended up not disabling the conflicting class. Alpha made a PR to fix this: caffeinemc/sodium-fabric#1953

theRookieCoder commented 1 year ago

Seems to have been fixed in https://github.com/CaffeineMC/sodium-fabric/commit/d0d6918cde31afbb5d3053a672041273bdc984a9, dev should be compatible now.

NalCol commented 1 year ago

Got it

ItsPoisonRed commented 1 year ago

how do I apply the fix? I need to use sodium 5.0.0 for the Physics mod, but that makes it incompatible for dashloader.

theRookieCoder commented 1 year ago

how do I apply the fix? I need to use sodium 5.0.0 for the Physics mod, but that makes it incompatible for dashloader.

Download and use the latest asset from GitHub Actions' dev branch. This is an unstable version, so unfortunately no guarantees it will be compatible with all your mods.

auyylaso commented 1 year ago

The latest version of DEV branch seemingly throws the exact same error with Dashloader unfortunately. Along with the git.d0d6918 build. But I do understand this really isn't your issue lol. Just thought I would post an update for anyone who was wondering if that dev action build worked.

alphaqu commented 1 year ago

I have not published the Dashloader side of the fix yet, I'm waiting for sodium to release first.

NotDarkn commented 1 year ago

issue still occurs with Sodium 0.5.1

CassieRoseZA commented 1 year ago

Still Occurs with Sodium 0.5.2

alphaqu commented 1 year ago

5.0.0-beta.2 should have fixed the issue. Do you guys have issues on that exact release?

theRookieCoder commented 1 year ago

5.0.0-beta.1 works properly with sodium 0.5.2 from my testing

heerxingen commented 8 months ago

5.0.0-beta.2 works with Sodium 0.5.2

heerxingen commented 8 months ago

5.0.0-beta.2 works with Sodium 0.5.2

wait I'm not so sure now.. let me check again

heerxingen commented 8 months ago

5.0.0-beta.2 works with Sodium 0.5.2

wait I'm not so sure now.. let me check again

5.0.0-beta.2 works with Sodium 0.5.2 and 0.5.3

NalCol commented 8 months ago

👍 humm