search

alphasoc / nfr

A lightweight tool to score network traffic and flag anomalies
https://alphasoc.com
Other
122 stars 19 forks source link

namescore versioning #3

Closed phob0s-pl closed 7 years ago

phob0s-pl commented 7 years ago

One of arguments for /v1/key/request is platform name and version.

How do you handle versioning? Hardcoding?

tg commented 7 years ago

I wouldn't worry about /v1/key/request as we don't use the values there in any context, however we'll need this for a proper User-Agent string when querying API (e.g. AlphaSOC Namescore/0.1). For now we can have it hardcoded, until we figure out company-wide versioning scheme and practice.

phob0s-pl commented 7 years ago

Done as you proposed.