alphaville / jaqpot3

A brand new version of jaqpot - fully OpenTox API (1.2) compliant (see http://opentox.ntua.gr ) - lots of new features
http://opentox.ntua.gr
2 stars 1 forks source link

URL-encoded URI in PMML #17

Closed alphaville closed 9 years ago

alphaville commented 10 years ago

In the PMML representation of a MLR model as it is produced currently by jaqpot, the URI of the dataset is URL-encoded:

<DatasetID href="http%3A%2F%2Fapps.ideaconsult.net%3A8080%2Fambit2%2Fdataset%2FR545"/>

See https://gist.github.com/alphaville/b55a1d1e64e7a52bf3c4

cURL command to reproduce the issue:

export token=`curl -X POST -k 'https://opensso.in-silico.ch:443/auth/authenticate?uri=service=openldap' -d username=guest -d password=guest 2> /dev/null`;
token=`echo $token | cut -c10-80`;
echo "[TOKEN] $token"
curl -X GET http://opentox.ntua.gr:8080/model/e5ebc96d-a5d4-47f8-9962-3e52c07901fb \
-H subjectid:$token \
-H Accept:application/xml

I see that at https://github.com/alphaville/jaqpot3/blob/master/jaqpot3-standalone/src/main/java/org/opentox/jaqpot3/qsar/util/PMMLGenerator.java#L77 there is an invocation to URLEncoder.encode - I'm not 100% sure that this is necessary. We should take a closer look and remove it if it's not necessary to encode it.

ghost commented 9 years ago

fixed