search

alphaville / optimization-engine

Nonconvex embedded optimization: code generation for fast real-time optimization + ROS support
https://alphaville.github.io/optimization-engine/
Other
512 stars 53 forks source link

Fix documentation link #261

Closed jannic closed 2 years ago

jannic commented 2 years ago

API doc says Note that this is the API documentation of Optimization Engine; to get started, you would rather check out the documentation., and then points back to itself. I guess this should have been a link to https://alphaville.github.io/optimization-engine/

alphaville commented 2 years ago

@jannic thank you spotting this typo and for your PR. We will include it in the next release, which is coming soon.

jannic commented 2 years ago

There are some more fixes in https://github.com/jannic/optimization-engine/commits/patch-2 I didn't have time to create a pull request (and wasn't sure which of the changes to submit), but feel free to pick commits directly from that branch if you like them.

alphaville commented 2 years ago

There are some more fixes in https://github.com/jannic/optimization-engine/commits/patch-2 I didn't have time to create a pull request (and wasn't sure which of the changes to submit), but feel free to pick commits directly from that branch if you like them.

Thanks a lot. I had a look at this commit. Doesn't f"{variable}" work in Python 3.5?

jannic commented 2 years ago

Thanks a lot. I had a look at this commit. Doesn't f"{variable}" work in Python 3.5?

Didn't work on Debian 9 (which has Python 3.5.3), and the patch fixed it for me. I think it's PEP 498, added in Python 3.6.0 (https://www.python.org/downloads/release/python-360/)