Closed alphaville closed 2 years ago
@Arun-R-M
A test case can be added that solves a known problem and calls the solver with initial_guess and p values and check against a hardcoded set of correct solution (possibly obtained from a previous version of opengen).
Good point, but we check whether the optimality conditions are satisfied and whether the solutions are feasible. I'll strengthen the unit test a little more.
@Arun-R-M further testing revealed a bug: preconditioning scales the cost function, but then when we return the optimal cost to the user we need to scale it back (to undo the scaling). I'm pushing a change now that will make a test fail, but I'll fix it.
Main Changes
Essentially, this PR finalises most of the tasks involved in #292.
In
optimizer.rs
:In
optimizer_builder.py
:psi
,grad_psi
,F1
andF2
become functions ofθ=(p, w)
instead of justp
In
interface.c
:w_cost
In
alm_optimizer_status.rs
Other
Halfspace
(missingfloat
)Associated Issues
TODOs
CHANGELOG
(Rust)