Scrutinizer error - Githubissues

alphazframework / framework

Core files of AlphaZ Framework

https://alphazframework.github.io/

MIT License

16 stars 17 forks source link

Scrutinizer error #209

Closed Maikuolan closed 5 years ago

Maikuolan commented 5 years ago

Currently seeing this message from scrutinizer:

composer

Not my area of expertise, so not something I could fix so easily, I think. Probably need to look more closely either at Composer package settings or at the unit tests, I think.

peter279k commented 5 years ago

@Maikuolan, thank you for your reply.

The Scrutinizer CI error due to the PHPUnit dependencies issue.

And I think we have the following suggestion to solve this:

Let this package be php:7.1 at least and define this about the require block in composer.json.
Define the PHPUnit version to be phpunit: "^7.0 || ^8.0" about require-dev block so that this dependencies issue will be solved.

lablnet commented 5 years ago

@Maikuolan thanks you so much for reporting the issue & @peter279k thanks you for resolving..

peter279k commented 5 years ago

@Lablnet, do we need to support the php-7.1 version?

Or require php-7.2 version at least?

lablnet commented 5 years ago

7.2

lablnet commented 5 years ago

Because we use phpUnit version 8

Maikuolan commented 5 years ago

Sounds good. :-)