search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Fix typos + wording. #215

Closed Maikuolan closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #215 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #215   +/-   ##
========================================
  Coverage      4.66%   4.66%           
  Complexity     1803    1803           
========================================
  Files           110     110           
  Lines          4605    4605           
========================================
  Hits            215     215           
  Misses         4390    4390
Impacted Files Coverage Δ Complexity Δ
src/Files/Files.php 0% <ø> (ø) 70 <0> (ø) :arrow_down:
src/Common/FTP.php 0% <ø> (ø) 40 <0> (ø) :arrow_down:
src/Common/Sitemap/Sitemap.php 0% <ø> (ø) 11 <0> (ø) :arrow_down:
src/Common/Sitemap/SitemapIndex.php 0% <ø> (ø) 8 <0> (ø) :arrow_down:
src/Console/Console.php 0% <0%> (ø) 18 <0> (ø) :arrow_down:
src/Whoops/views/view.php 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 355e0b2...7e16103. Read the comment docs.

Maikuolan commented 5 years ago

@peter279k @Lablnet Review requested. :-)

(( I built a simple script earlier today, to scan repositories for possible typos, to make life easier. I needed something to test it with. 😛 Changes and commits were done manually, but I used this script to find the typos in the first place. ))

Maikuolan commented 5 years ago

Not sure why codecov/patch doesn't like these commits. Report page is difficult to understand. I understand there is a +1 of.. something.. but I'm not sure how to get more information from that.

peter279k commented 5 years ago

BTW, could you squash all commits to one commit?

And I think this can let us look at these changes clearly.

Maikuolan commented 5 years ago

and I think we can ignore the codecov/patch because these changes will not effect the diff code coverage.

That's good news. :-)

BTW, could you squash all commits to one commit?

And I think this can let us look at these changes clearly.

Sure, I can do that. I'll sort that out now.

Maikuolan commented 5 years ago

Squash done.

lablnet commented 5 years ago

@Maikuolan Thanks you so much for your contribution appreciated, and good luck for your script.

@peter279k thanks you too for your response