search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Enhancement of Arrays class #223 #224

Closed lablnet closed 5 years ago

lablnet commented 5 years ago

Enhancement of Arrays class #223

codecov[bot] commented 5 years ago

Codecov Report

Merging #224 into master will increase coverage by 0.25%. The diff coverage is 23.8%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #224      +/-   ##
===========================================
+ Coverage      5.01%   5.26%   +0.25%     
- Complexity     1812    1839      +27     
===========================================
  Files           111     111              
  Lines          4629    4692      +63     
===========================================
+ Hits            232     247      +15     
- Misses         4397    4445      +48
Impacted Files Coverage Δ Complexity Δ
src/Data/Arrays.php 66.84% <23.8%> (-21.87%) 91 <27> (+27)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 481ce7f...1bfc1e6. Read the comment docs.

peter279k commented 5 years ago

The assertions are failed in Travis CI build.

You should try to fix that.

Here is the failed assertion captured picture:

image

peter279k commented 5 years ago

The assertions are failed in Travis CI build.

You should try to fix that.

Here is the failed assertion captured picture:

image

It seems that the expected associative array should change the order.

peter279k commented 5 years ago

The Travis CI build is failed.

PHP Fatal error:  Class Zest\Data\Arrays contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods

The Arrays class should implement all methods which defined in specific interface.

lablnet commented 5 years ago

@peter279k see Arrays class all method defined

peter279k commented 5 years ago

I think it is ready to be merged.

Before merging the PR, we should fix coding style.

lablnet commented 5 years ago

@peter279k What about the tests that left and one method => pluck ?

peter279k commented 5 years ago

@peter279k What about the tests that left and one method => pluck ?

I think we can create another PR to enhance the Array test.

lablnet commented 5 years ago

Okay sure let me finish the tests for random, where, shuffle and query method