search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Enchantment of str class #247

Closed lablnet closed 4 years ago

lablnet commented 4 years ago

As title, enchantment of str Class

Need encoding support.

May need more methods like

  1. hasUpperCase
  2. hasLowerCase
  3. ConvertCase
  4. etc...
ghost commented 4 years ago

hey, do you have any coding guidelines? And do you have any other special wishes what kind of methods you need or should I just add everything that comes into my mind?

lablnet commented 4 years ago

hey, do you have any coding guidelines? And do you have any other special wishes what kind of methods you need or should I just add everything that comes into my mind?

Yes have coding guide 1.You never allow add third-party Composer dependencies or classes 2.You allow to improve existing features or add new features

  1. You allow update Zest framework code or core code
  2. When you want send pull request. You have provide brief description about code either you update exsting code or adding new feature. In short every change you made should be standalone.

You may add everything that is in your mind You may also consider this

hasUpperCase hasLowerCase ConvertCase

Thanks you for being interest in Contribution of Zest Framework

peter279k commented 4 years ago

@Lablnet, we also consider adding the unit tests for Str class.

And it can be reliable for Str class method behaviors.

lablnet commented 4 years ago

@Lablnet, we also consider adding the unit tests for Str class.

And it can be reliable for Str class method behaviors.

Yeah, it already been their

look

https://github.com/zestframework/Zest_Framework/blob/master/Tests/Data/StrTest.php