search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Add isBase64 and substring methods to Str class #272

Closed 2mt-heuser closed 5 years ago

2mt-heuser commented 5 years ago

As requested in https://github.com/zestframework/Zest_Framework/issues/271 I added two new statics to:

a) check if a string is a valid base64 encoded string b) return a substring of given string

and added corresponding tests as well.

codecov[bot] commented 5 years ago

Codecov Report

Merging #272 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #272      +/-   ##
===========================================
+ Coverage       8.8%   8.87%   +0.07%     
- Complexity     1904    1906       +2     
===========================================
  Files           110     110              
  Lines          4818    4822       +4     
===========================================
+ Hits            424     428       +4     
  Misses         4394    4394
Impacted Files Coverage Δ Complexity Δ
src/Data/Str.php 87.23% <100%> (+1.18%) 21 <2> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d26ce8...92df46a. Read the comment docs.

peter279k commented 5 years ago

The Travis CI build is failed, but it's not related to this PR.

I will ignore CI build at this moment and focus on reviewing code changes.

lablnet commented 5 years ago

@2mt-heuser Thanks you so much for your time to contribute

Really appropriated.

2mt-heuser commented 5 years ago

@2mt-heuser Thanks you so much for your time to contribute

Really appropriated.

You're welcome. When I find more time between work I'll take a look at some other methods and/or issues.