search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Fix behaviour of hasUppercase and hasLowercase #280

Closed 2mt-heuser closed 4 years ago

2mt-heuser commented 4 years ago

Regarding https://github.com/zestframework/Zest_Framework/issues/274 how about this implementation of hasUpper/Lower?

Would that have any drawbacks?

codecov[bot] commented 4 years ago

Codecov Report

Merging #280 into master will decrease coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #280      +/-   ##
===========================================
- Coverage      8.87%   8.72%   -0.16%     
+ Complexity     1906    1902       -4     
===========================================
  Files           110     110              
  Lines          4822    4814       -8     
===========================================
- Hits            428     420       -8     
  Misses         4394    4394
Impacted Files Coverage Δ Complexity Δ
src/Data/Str.php 84.61% <100%> (-2.62%) 17 <2> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ccf45a...ebda1fe. Read the comment docs.

lablnet commented 4 years ago

Thanks you so much for your time .