Cloudcov key is in the travis config

alphazframework / framework

Core files of AlphaZ Framework

https://alphazframework.github.io/

MIT License

16 stars 17 forks source link

Cloudcov key is in the travis config #282

Closed ReeceM closed 4 years ago

ReeceM commented 4 years ago

Describe the bug The Travis CI config file contains the CODECOV_TOKEN, this goes against standards to keep tokens in the runtime config of the service dashboard and not commit this data to git or revision control.

The way to fix this is to remove the config details and add it as an environment variable under Travis Ci:

Projects > Zest Framework Repo > Settings > Environment Variables.

Add the token there and it will still work.

Requirements Applies to the repo, not the running of main framework

lablnet commented 4 years ago

There is no such option

ReeceM commented 4 years ago

Hi @Lablnet, that setting is meant to be set in from the travis-ci section.

If you follow the following link https://travis-ci.org/zestframework/Zest_Framework/settings

You should be logged in and also be able to see the settings tab selected. That should be where you are able to change that.

The below is a screenshot of one of my repos, you should see the similar page:

peter279k commented 4 years ago

That's right. Token should not be exposed on Travis setting.

It should be a encrypted environment variables.

lablnet commented 4 years ago

@ReeceM Thanks you so much for your time