search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Update FileInfo.php #298

Closed ossamamehmood closed 4 years ago

ossamamehmood commented 4 years ago

The sha256 is more secured, then md5

codecov[bot] commented 4 years ago

Codecov Report

Merging #298 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage     10.06%   10.06%           
  Complexity     1927     1927           
=========================================
  Files           112      112           
  Lines          4869     4869           
=========================================
  Hits            490      490           
  Misses         4379     4379
Impacted Files Coverage Δ Complexity Δ
src/Files/FileInfo.php 0% <0%> (ø) 8 <4> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9843d5a...ad41187. Read the comment docs.

peter279k commented 4 years ago

The md5 and sha-1 are not secure anymore.

Please deprecate them or throw exception to notify developers don't do that...

lablnet commented 4 years ago

The md5 and sha-1 are not secure anymore.

Please deprecate them or throw exception to notify developers don't do that...

That's right so which algo should be used to make it more secured?

you may open PR