alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

fix for #220 #311

Closed lablnet closed 3 years ago

lablnet commented 3 years ago

https://github.com/zestframework/Zest_Framework/issues/220

codecov[bot] commented 3 years ago

Codecov Report

Merging #311 (c198c42) into master (0fdbfe7) will increase coverage by 1.24%. The diff coverage is 66.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
+ Coverage     10.22%   11.47%   +1.24%     
- Complexity     1916     1966      +50     
============================================
  Files           111      114       +3     
  Lines          5114     5196      +82     
============================================
+ Hits            523      596      +73     
- Misses         4591     4600       +9     
Impacted Files Coverage Δ Complexity Δ
src/Archive/Archive.php 0.00% <0.00%> (ø) 7.00 <7.00> (?)
src/Archive/Adapter/Zip.php 69.23% <69.23%> (ø) 26.00 <26.00> (?)
src/Archive/Adapter/Bzip.php 88.00% <88.00%> (ø) 15.00 <15.00> (?)
src/Archive/Adapter/Gzip.php 88.46% <88.46%> (ø) 15.00 <15.00> (?)
src/Time/Time.php 79.24% <0.00%> (+1.88%) 24.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fdbfe7...d04a2f0. Read the comment docs.

lablnet commented 3 years ago

@Maikuolan tests pass in gh actions

peter279k commented 3 years ago

coding style error should be concerned.

lablnet commented 3 years ago

coding style error should be concerned.

there is no such error, its giving that in other file which is out of scope in sense of current PR

peter279k commented 3 years ago

coding style error should be concerned.

there is no such error, its giving that in other file which is out of scope in sense of current PR

Right. Without coding style error, I think it should be good to merge this PR.