alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Update php.yml #315

Closed lablnet closed 3 years ago

peter279k commented 3 years ago

The GitHub Action setting should be improved and here are errors during PHPUnit executing unit tests:

There were 6 errors:

1) Framework\Tests\EncryptionTest::testSodiumEncrypt
Exception: The sodium php extension does not installed or enabled

/github/workspace/src/Encryption/Adapter/SodiumEncryption.php:29
/github/workspace/Tests/Encryption/EncryptionTest.php:22

2) Framework\Tests\TimeTest::testDaysInMonth with data set #0 (2, 2019, 28)
Error: Call to undefined function Zest\Time\cal_days_in_month()

/github/workspace/src/Time/Time.php:111
/github/workspace/Tests/Time/TimeTest.php:38

3) Framework\Tests\TimeTest::testDaysInMonth with data set #1 (3, 2019, 31)
Error: Call to undefined function Zest\Time\cal_days_in_month()

/github/workspace/src/Time/Time.php:111
/github/workspace/Tests/Time/TimeTest.php:38

4) Framework\Tests\TimeTest::testDaysInMonth with data set #2 (4, 2019, 30)
Error: Call to undefined function Zest\Time\cal_days_in_month()

/github/workspace/src/Time/Time.php:111
/github/workspace/Tests/Time/TimeTest.php:38

5) Framework\Tests\TimeTest::testDaysInMonth with data set #3 (2, 2012, 29)
Error: Call to undefined function Zest\Time\cal_days_in_month()

/github/workspace/src/Time/Time.php:111
/github/workspace/Tests/Time/TimeTest.php:38

6) Framework\Tests\TimeTest::testDaysInMonth with data set #4 (2, 2016, 29)
Error: Call to undefined function Zest\Time\cal_days_in_month()

/github/workspace/src/Time/Time.php:111
/github/workspace/Tests/Time/TimeTest.php:38

ERRORS!
Tests: 88, Assertions: 158, Errors: 6, Skipped: 4.
lablnet commented 3 years ago

@peter279k the first two errors make sense because sodium php extension is required. but the error in Time class i didn't able to understand because in TimeTest we didn't call any such function cal_days_in_month

peter279k commented 3 years ago

Letting me check how to fix above issue I mention at my available time.