Closed Maikuolan closed 3 years ago
The failed test is as follows:
There were 2 errors:
1) Framework\Tests\Archive\GzipTest::testExtract
gzopen(/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/Zest.png.gz): Failed to open stream: `9' is not a valid mode for fopen
/home/runner/work/Zest_Framework/Zest_Framework/src/Archive/Adapter/Gzip.php:87
/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/GzipTest.php:14
2) Framework\Tests\Archive\GzipTest::testCompress
gzopen(/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/Zest.png.gz): Failed to open stream: `9' is not a valid mode for fopen
/home/runner/work/Zest_Framework/Zest_Framework/src/Archive/Adapter/Gzip.php:87
/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/GzipTest.php:26
According to the gzopen function usage, the default $mode
9
is not valid for second argument on gzopen()
function.
The problematic code is available here and it causes failed Gzip
tests:
According to the gzopen function usage, the default
$mode
9
is not valid for second argument ongzopen()
function.
Good catch. :-)
But, seeing as this particular PR only deals with the README file, if possible, let's open a new, separate PR to deal with the Gzip test failures. :+1:
I'll create a new PR now for the Gzip tests.
Done (#341).
Replaces
softhub99/zest_framework
(marked as abandoned at Packagist) withzest/framework
(Zest's current package identity).