alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Update package references in README. #340

Closed Maikuolan closed 3 years ago

Maikuolan commented 3 years ago

Replaces softhub99/zest_framework (marked as abandoned at Packagist) with zest/framework (Zest's current package identity).

peter279k commented 3 years ago

The failed test is as follows:

There were 2 errors:

1) Framework\Tests\Archive\GzipTest::testExtract
gzopen(/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/Zest.png.gz): Failed to open stream: `9' is not a valid mode for fopen

/home/runner/work/Zest_Framework/Zest_Framework/src/Archive/Adapter/Gzip.php:87
/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/GzipTest.php:14

2) Framework\Tests\Archive\GzipTest::testCompress
gzopen(/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/Zest.png.gz): Failed to open stream: `9' is not a valid mode for fopen

/home/runner/work/Zest_Framework/Zest_Framework/src/Archive/Adapter/Gzip.php:87
/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/GzipTest.php:26

According to the gzopen function usage, the default $mode 9 is not valid for second argument on gzopen() function.

peter279k commented 3 years ago

The problematic code is available here and it causes failed Gzip tests:

Maikuolan commented 3 years ago

According to the gzopen function usage, the default $mode 9 is not valid for second argument on gzopen() function.

Good catch. :-)

But, seeing as this particular PR only deals with the README file, if possible, let's open a new, separate PR to deal with the Gzip test failures. :+1:

Maikuolan commented 3 years ago

Found the origin:

https://github.com/zestframework/Zest_Framework/commit/f41b098af6aac148eac68e3dbba0ebac9ce794c8#diff-2b1361607945a8d7663b9ee08966ac0d223c481cdf19dbfacdf6ecbfffd2a121R74

Maikuolan commented 3 years ago

I'll create a new PR now for the Gzip tests.

Maikuolan commented 3 years ago

Done (#341).