alpheios-project / alpheios-core

Alpheios Core Javascript Packages and Libraries
15 stars 2 forks source link

display problem with deduping of features from lemma #142

Open monzug opened 4 years ago

monzug commented 4 years ago

double click on Αἰγύπτου in text environment (Safari - Alpheios Components 1.4.7) https://texts-test.alpheios.net/text/urn:cts:greekLit:tlg0085.tlg001.alpheios-text-grc1/passage/1-30

Gen is repeated twice and also we have both the masculine and feminine when the word is feminine see screenshot Screen Shot 2019-11-08 at 3 22 42 PM

monzug commented 4 years ago

looking at Morpheus, we say feminine, the decl and the noun

Αἴγυπτος noun 2nd feminine

then we say feminine and masculine again in

Αἰγυπτ ου noun 2nd genitive feminine singular os_ou Αἰγυπτ ου noun 2nd genitive masculine singular os_ou
monzug commented 4 years ago

also there is a difference in the morphology popup when I double click the above word vs when I lookup for Αἰγύπτου

Screen Shot 2019-11-08 at 3 44 42 PM

monzug commented 4 years ago

same in Chrome

balmas commented 4 years ago

the repetition issue is reported in alpheios-project/alpheios-core#101 What makes it look odd here is that we aren't showing the gender after the first instance of the case. e.g. We would normally show this as gen. (f.) gen. (m) . But in this situation, the dictionary entry also has the gender included, as feminine, and so we are deduping the gender out of the instance of the inflection case that is feminine. I don't know how often this occurs -- e.g. see φανέντος for which the dictionary entry has no gender:

Alpheios Texts

Need to think about what to do here, if we want to drop the deduping and if so, in all situations, all languages, or just select ones.

balmas commented 4 years ago

also there is a difference in the morphology popup when I double click the above word vs when I lookup for Αἰγύπτου

the difference in output is due to the treebank disamibugation, Which I think is actually a separate bug.