Open balmas opened 4 years ago
@irina060981 can you give this a try? You can take a look at what we do in the Traces engine for the link to Sedra.
I was thinking that we can move the wrapping of the definition in the ResourceProviderProxy to the engine-specific parseMeaning function.
Let me know if you have trouble finding enough Syriac words to test and develop with. I had added one fixture but we probably need more. You can use the Sedra lookup tool at http://sedra.bethmardutho.org/lexeme/get and the keyboard they have there to get some words using the autocomplete
@balmas, I have examined the way that we could add definitions. We have separate definitions for Greek, for example
But we have the main difference here. For Greek we currently none - what exactly provider we have - each source (provider) has its own config data in config json, and each definition is connected to one source.
But here we have the other structure (I believe). For example for the given word - the first lexicon - ܘܐܡܪܝܢ https://morph.alpheios.net/api/v1/analysis/word?word=%DC%98%DC%90%DC%A1%DC%AA%DC%9D%DC%A2&engine=sedra&lang=syr&clientId=embed-lib-index-demo
we have the following short definitions:
and separately the following source data
and that's why we have the following problems:
but, if we could solve this moments, we could do the requested structure, I think.
@balmas , what do you think?
yes you're right we don't have a way to tie the individual meanings to their sources. I'll check with the Sedra team to see if they want to make that change to enable a link between the meanings and the sources, or if they just want us to aggregate and dedupe them. Stay tuned :-)
taking this one back for now
for sources, George would like to try something like the following (modeled after the ge'ez approach)
Credits Sedra [with a link to sedra.bethmardutho.org], Georg A. Kiraz (General Editor), James W. Bennet (IT Manager) Dictionary1Abbreiviaiton =
Dictionary2Abbreivation =
(but don't duplicate if an abbreviation appears more than once and list them in alphabetical order of the abbreviations)
Originally posted by @balmas in https://github.com/alpheios-project/alpheios-core/issues/162#issuecomment-589675162