search

alpheios-project / alpheios-core

Alpheios Core Javascript Packages and Libraries
15 stars 2 forks source link

partial word items can be saved if storage gets interrupted by page reload #460

Open monzug opened 4 years ago

monzug commented 4 years ago

I just created a new user as part of regression. when switching from one Latin book to an other, I have to double click on the selected book which generates a quick pop-up (barely notable). In wordlist, I can see the title (or part of it) been added with no date. when I double click on it, it does load for ever. see screenshots: 1) titles added to wordlist with no dates historical-added-wordlist 2) double click on title, pop-up loads for ever historical-from-wordlist

monzug commented 4 years ago

Just to clarify, a single click works to select the book. I am not sure about the missing date to the title in wordlist and that double-clicking on the titles generates a pop-up that loads for ever.

balmas commented 4 years ago

I can reproduce. Investigating.

balmas commented 4 years ago

Ok, I see why this is happening. It's can happen in the situation where a request to store a new word gets interrupted by a page reload. In this case, the double click on the title starts the storage of a new word, and that gets interrupted when the page switches, so the sequence of saving to remote storage doesn't finish.

This isn't a new issue, but it's now possible to see it more clearly because the initial word item creation doesn't set the updatedDT and frequency fields, since we are trying to support both old and new wordItems and the old wordItems don't have these fields. We should probably have used wordItem versioning to handle the backwards compatibility better.

I'm not sure why the double-click on the word once added causes the query to fail (i.e .the Loading message to appear forever), I couldn't reproduce that part of this issue.

However, I believe this is an edge case and fixing it requires going a bit too far into the guts of the wordlist code at this stage of the release, so I'm going to postpone it.

We do need to make our user data handling more robust over all going forward.

monzug commented 4 years ago

ah, that's why. I didn't think that the reloading was actually interrupting the process of storing the word. Thanks.

On Wed, Jun 17, 2020 at 9:47 AM Bridget Almas notifications@github.com wrote:

Ok, I see why this is happening. It's can happen in the situation where a request to store a new word gets interrupted by a page reload. In this case, the double click on the title starts the storage of a new word, and that gets interrupted when the page switches, so the sequence of saving to remote storage doesn't finish.

This isn't a new issue, but it's now possible to see it more clearly because the initial word item creation doesn't set the updatedDT and frequency fields, since we are trying to support both old and new wordItems and the old wordItems don't have these fields. We should probably have used wordItem versioning to handle the backwards compatibility better.

I'm not sure why the double-click on the word once added causes the query to fail (i.e .the Loading message to appear forever), I couldn't reproduce that part of this issue.

However, I believe this is an edge case and fixing it requires going a bit too far into the guts of the wordlist code at this stage of the release, so I'm going to postpone it.

We do need to make our user data handling more robust over all going forward.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/alpheios-core/issues/460#issuecomment-645383928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOKVO2NEP47Z6GKKTQLRXDCNPANCNFSM4OAR3IJQ .

balmas commented 4 years ago

assigning to @kirlat to think about in the wordlist refactoring