search

alpheios-project / alpheios-core

Alpheios Core Javascript Packages and Libraries
15 stars 2 forks source link

fix and reinstate vue tooltip component test #534

Open balmas opened 4 years ago

balmas commented 4 years ago

there is something about the Vue component tooltip test that causes the test suite to hang when it is run in the CI environments (it hangs on both Travis and GitHub Actions).

I don't think it's related to a change in the Alpheios code, because the same builds that succeeded ~> 1 week ago are failing when rerun now. It's not a difference in a top-level dependency, because the dependencies in the package-lock.json are no different on a build that succeeded and one that failed. It could be a low-level dependency in node_modules, but I have no idea which one.

I suspect that if we cleanup the way the vuex store is being handled in this test it should resolve it -- it looks like it wasn't updated to use the BaseTestHelp methods (I started down that path but each test case creates its own store so it needs a bit more work).

For now I have disabled the test (by making it into a backup fie). @kirlat when you have time can you take a look at this? It's not urgent but we should fix it before our next release.

kirlat commented 4 years ago

Sure, will be glad to fix it!

kirlat commented 3 years ago

This should be fixed by 856d9dfd2e262882ae0383b1419ca921d2955c34. I'm still not sure why was it happening. It was probably something related to the way Vue Test Utls work internally. Maybe it takes time for each change to apply and we need to wait for the previous one to finish before applying the next one. But anyway, the fix in 856d9dfd2e262882ae0383b1419ca921d2955c34 seems to be enough to solve this.