alpheios-project / alpheios-core

Alpheios Core Javascript Packages and Libraries
15 stars 2 forks source link

interpret morph attribute irreg_comp as comparative #573

Closed balmas closed 3 years ago

balmas commented 3 years ago

it looks like the issue is that we just take the first sense from the lexicon, "single" for the short definition and it would probably be better to extend this to e.g. "single, simple straightforward".

It's not about the sense, it's about the degree of comparison of the adjective, which should be presented in the form definition. Like you do in similar cases: image

Originally posted by @demophobos in https://github.com/alpheios-project/webextension/issues/316#issuecomment-742627445

balmas commented 3 years ago

morpheus normally reports the comparative in the comp field, as in:

<entry uri="">
          <dict>
            <hdwd xml:lang="grc">ἥμερος</hdwd>
            <pofs order="2">adjective</pofs>
            <decl>1st &amp; 2nd</decl>
          </dict>
          <infl>
            <term xml:lang="grc">
              <stem>ἡμερ</stem>
              <suff>ώτερον</suff>
            </term>
            <pofs order="2">adjective</pofs>
            <decl>1st &amp; 2nd</decl>
            <gend>adverbial</gend>
            <comp>comparative</comp>
            <stemtype>os_h_on</stemtype>
          </infl>
....

But for ἁπλούστερον (and probably others) the comp field is missing and instead we have irreg_comp in the morph field.

  <entry uri="">
          <dict>
            <hdwd xml:lang="grc">ἁπλόος</hdwd>
            <pofs order="2">adjective</pofs>
            <decl>1st &amp; 2nd</decl>
          </dict>
          <infl>
            <term xml:lang="grc">
              <stem>ἁπλουστερ</stem>
              <suff>ον</suff>
            </term>
            <pofs order="2">adjective</pofs>
            <decl>1st &amp; 2nd</decl>
            <case order="4">accusative</case>
            <gend>masculine</gend>
            <num>singular</num>
            <stemtype>os_h_on</stemtype>
            <morph>irreg_comp</morph>
          </infl>
...

We could normalize this in the client adapter code.

balmas commented 3 years ago

we should also catch and map the irreg_superl morph attribute value to comp=superlative

e.g. as in ἥδιστα and ἄριστα

balmas commented 3 years ago

can be tested in Alpheios Components 3.3.1-qa.20210106574

monzug commented 3 years ago

tested in FF/Mac in Alpheios Reading Tools 3.3.1 build qa.20210106631 Alpheios Components 3.3.1-qa.20210106574 - I am getting the comparative and super attribute now.

two questions:

1) ἄριστα does not have the super attribute in the morphology pop-up. I did also checked on morpheus and there is nothing that says it's a superlative.

2) Would it be possible to add the attribute only once e.g. next to plural? see attachment

Screen Shot 2021-01-07 at 3 15 26 PM

balmas commented 3 years ago

Would it be possible to add the attribute only once e.g. next to plural? see attachment

I think the grouping is a similar issue to #101 and #336. I don't think I can fix that now but the grouping needs to be redone in the next major release.

balmas commented 3 years ago

ἄριστα does not have the super attribute in the morphology pop-up. I did also checked on morpheus and there is nothing that says it's a superlative.

Yeah that's a morpheus bug. Will record it there.

monzug commented 3 years ago

yep, remember the grouping issues. I thought that maybe the superlative and comparative could be handled differently. Oh well, soon

On Thu, Jan 7, 2021 at 6:45 PM Bridget Almas notifications@github.com wrote:

ἄριστα does not have the super attribute in the morphology pop-up. I did also checked on morpheus and there is nothing that says it's a superlative.

Yeah that's a morpheus bug. Will record it there.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/alpheios-core/issues/573#issuecomment-756271256, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOKAD4HRZ6VWM2WRWD3SYXXKZANCNFSM4UVJ5FFQ .

monzug commented 3 years ago

tested also with Greek comparative : θειότερον σεμνότερόν γλύκιόν